-
-
Notifications
You must be signed in to change notification settings - Fork 465
Add AI rules files for Profiling #5034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Add AI rules files for Profiling ([#5034](https://github.com/getsentry/sentry-java/pull/5034))If none of the above apply, you can opt out of this check by adding |
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Deps
Other
Other
🤖 This preview updates automatically when you update the PR. |
adinauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether it's best to have Android and JVM profiling in the same file or whether it's better to create separate files. ATM most of the content is specific to JVM profiling.
We could have:
profiling_jvm.mdcprofiling_anrdoid.mdc
Not sure if subdirs would work across agents, e.g. jvm/profiling.mdc and android/profiling.mdc.
| --- | ||
| # Java SDK Profiling | ||
|
|
||
| The Sentry Java SDK provides continuous profiling through the `sentry-async-profiler` module, which integrates async-profiler for low-overhead CPU profiling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is already specific to JVM profiling. I'd move this under a JVM section.
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps